-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, two things to take care of:
- CSS/SCSS indentation
- Check why some of the shared styles are coming from what should be a specific stylesheet like homepage.scss
other than that, looks good!
Reviewed 9 of 9 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @RitaOak)
style/context.scss, line 9 at r1 (raw file):
} .navbar-item.has-dropdown {
wrong indentation, did you lint this before committing?
style/notifications.scss, line 8 at r1 (raw file):
border-color: #0060df; }
same here, indent it with some tool via vscode for instance
style/user.scss, line 8 at r1 (raw file):
border-color: #0060df; }
same here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @brecke)
style/context.scss, line 9 at r1 (raw file):
Previously, brecke (Miguel Laginha) wrote…
wrong indentation, did you lint this before committing?
Done.
style/notifications.scss, line 8 at r1 (raw file):
Previously, brecke (Miguel Laginha) wrote…
same here, indent it with some tool via vscode for instance
Done.
style/user.scss, line 8 at r1 (raw file):
Previously, brecke (Miguel Laginha) wrote…
same here.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
This change is