Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

Interface resize #25

Merged
merged 6 commits into from
Dec 5, 2019
Merged

Interface resize #25

merged 6 commits into from
Dec 5, 2019

Conversation

RitaOak
Copy link
Collaborator

@RitaOak RitaOak commented Dec 3, 2019

This change is Reviewable

@RitaOak RitaOak requested a review from brecke December 3, 2019 22:54
Copy link
Member

@brecke brecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, two things to take care of:

  • CSS/SCSS indentation
  • Check why some of the shared styles are coming from what should be a specific stylesheet like homepage.scss

other than that, looks good!

Reviewed 9 of 9 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @RitaOak)


style/context.scss, line 9 at r1 (raw file):

  }
    
    .navbar-item.has-dropdown {

wrong indentation, did you lint this before committing?


style/notifications.scss, line 8 at r1 (raw file):

  border-color: #0060df;
}
  

same here, indent it with some tool via vscode for instance


style/user.scss, line 8 at r1 (raw file):

    border-color: #0060df;
  }
    

same here.

@RitaOak RitaOak requested a review from brecke December 5, 2019 13:03
Copy link
Collaborator Author

@RitaOak RitaOak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @brecke)


style/context.scss, line 9 at r1 (raw file):

Previously, brecke (Miguel Laginha) wrote…

wrong indentation, did you lint this before committing?

Done.


style/notifications.scss, line 8 at r1 (raw file):

Previously, brecke (Miguel Laginha) wrote…

same here, indent it with some tool via vscode for instance

Done.


style/user.scss, line 8 at r1 (raw file):

Previously, brecke (Miguel Laginha) wrote…

same here.

Done.

Copy link
Member

@brecke brecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@RitaOak RitaOak merged commit d554420 into oaeproject:master Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants